Skip to content

Commit

Permalink
Bug 1934146. Only build compositor hit test info if we are painting t…
Browse files Browse the repository at this point in the history
…o the window. r=layout-reviewers,emilio

If we aren't painting to the window then the hit test info has no where to go as we must be painting to a flat simple surface.

I moved the bools closer together so they doesn't require two memory reads.

A couple of less fuzzy required in reftest snapshot due to no longer having hit test info items.

Differential Revision: https://phabricator.services.mozilla.com/D230629

UltraBlame original commit: 15ed73287645c809601c764e4d200f6e2009728b
  • Loading branch information
marco-c committed Dec 1, 2024
1 parent 8c78121 commit 0934f7f
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 30 deletions.
29 changes: 10 additions & 19 deletions layout/painting/nsDisplayList.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3680,6 +3680,16 @@ mIsPaintingToWindow
(
false
)
mAsyncPanZoomEnabled
(
nsLayoutUtils
:
:
AsyncPanZoomEnabled
(
aReferenceFrame
)
)
mUseHighQualityScaling
(
false
Expand Down Expand Up @@ -3718,16 +3728,6 @@ mContainsNonMinimalDisplayPort
(
false
)
mAsyncPanZoomEnabled
(
nsLayoutUtils
:
:
AsyncPanZoomEnabled
(
aReferenceFrame
)
)
mBuildingInvisibleItems
(
false
Expand Down Expand Up @@ -3778,15 +3778,6 @@ MOZ_COUNT_CTOR
nsDisplayListBuilder
)
;
mBuildCompositorHitTestInfo
=
mAsyncPanZoomEnabled
&
&
IsForPainting
(
)
;
ShouldRebuildDisplayListDueToPrefChange
(
)
Expand Down
14 changes: 7 additions & 7 deletions layout/painting/nsDisplayList.h
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,10 @@ BuildCompositorHitTestInfo
const
{
return
mBuildCompositorHitTestInfo
mAsyncPanZoomEnabled
&
&
mIsPaintingToWindow
;
}
bool
Expand Down Expand Up @@ -5655,6 +5658,9 @@ bool
mIsPaintingToWindow
;
bool
mAsyncPanZoomEnabled
;
bool
mUseHighQualityScaling
;
bool
Expand All @@ -5679,9 +5685,6 @@ bool
mContainsNonMinimalDisplayPort
;
bool
mAsyncPanZoomEnabled
;
bool
mBuildingInvisibleItems
;
bool
Expand All @@ -5691,9 +5694,6 @@ bool
mInInvalidSubtree
;
bool
mBuildCompositorHitTestInfo
;
bool
mDisablePartialUpdates
;
bool
Expand Down
4 changes: 2 additions & 2 deletions layout/reftests/bugs/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -31268,10 +31268,10 @@ fuzzy
if
(
useDrawSnapshot
33
0
-
33
218
0
-
218
)
Expand Down
4 changes: 2 additions & 2 deletions layout/reftests/transform-3d/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -2044,10 +2044,10 @@ fuzzy
if
(
useDrawSnapshot
4
0
-
4
13
0
-
13
)
Expand Down

0 comments on commit 0934f7f

Please sign in to comment.