Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed Datatype of tmpc_keep_time #202

Merged
merged 1 commit into from
Feb 18, 2024
Merged

changed Datatype of tmpc_keep_time #202

merged 1 commit into from
Feb 18, 2024

Conversation

maxwai
Copy link
Collaborator

@maxwai maxwai commented Feb 18, 2024

No description provided.

@maxwai maxwai added ready for review PR is ready for review Database Migration Adding Database Migration labels Feb 18, 2024
@maxwai maxwai added this to the SS23 milestone Feb 18, 2024
@maxwai maxwai self-assigned this Feb 18, 2024
Copy link
Collaborator

@byte-sized-emi byte-sized-emi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm just not sure why this is done - I'm sure you have a reason, feel free to merge

@maxwai
Copy link
Collaborator Author

maxwai commented Feb 18, 2024

this is done, since actually this data is an amount of hours and not an actual time.

@byte-sized-emi
Copy link
Collaborator

alright. Don't think it's entirely wrong to store it as a timestamp, but fair enough

@byte-sized-emi byte-sized-emi merged commit 7f6ac29 into main Feb 18, 2024
3 checks passed
@byte-sized-emi byte-sized-emi deleted the sql_migration branch February 18, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database Migration Adding Database Migration ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants