Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL methods #189

Merged
merged 37 commits into from
Dec 21, 2023
Merged

SQL methods #189

merged 37 commits into from
Dec 21, 2023

Conversation

maxwai
Copy link
Collaborator

@maxwai maxwai commented Nov 17, 2023 •
edited
Loading

Added first batch of Methods. For now these should be enough. If more are needed later while writing the bot, these will be added at that time.

@maxwai
made method to check if a guild is in the database
6e9ed05
@maxwai
added migration to make foreign keys cascade.
4d582f2 
It is made so that Channel or Roles can change (except tmpc voice channels) but the guild id can't change.
Every foreign key can be deleted.
@maxwai
extracted method
e1117c2
@maxwai
added insert and delete guild methods
720a7f1
@maxwai maxwai added the WIP PR is WIP label Nov 17, 2023
@maxwai maxwai added this to the SS23 milestone Nov 17, 2023
@maxwai maxwai self-assigned this Nov 17, 2023
@maxwai maxwai linked an issue Nov 17, 2023 that may be closed by this pull request
Add database methods #138
Closed
maxwai added 22 commits November 19, 2023 14:43
@maxwai
fixed datatypes
902effc
@maxwai
added get_guild function
da0b407
@maxwai
Merge branch 'main' into sql_methods
ba8c919
@maxwai
changed unused to dead_code
a74b956
@maxwai
removed imports
53589e7
@maxwai
updated documentation
a8cb9f0
@maxwai
formatting
5aa2e28
@maxwai
added update ghost warning deadline function
2c3420e
@maxwai
fixed clippy problems
98a9b5b
@maxwai
added all setters for the fields in the guild table
37b69c2
@maxwai
Merge branch 'main' into sql_methods
cfafa97
@maxwai
added structs needed
0d78c42
@maxwai
moved function out of test to be able to use later
15b5a1a
@maxwai
added alumni role functions
f1e2167
@maxwai
added study group functions
320fc8a
@maxwai
added semester study group functions
15f3e81
@maxwai
added subject functions
8e1348b
@maxwai
added Study-Subject Link functions
f3f58ec
@maxwai
added Tmpc Join Channel functions
dec85f3
@maxwai
added Tmpc functions
34c2b12
@maxwai
added token message functions
7e30ba3
@maxwai
added final set of functions to change values in the database
e6a0d6d
@maxwai maxwai added next-semester This is only needed for the start of the next Semester Prio 1 ready for review PR is ready for review and removed WIP PR is WIP next-semester This is only needed for the start of the next Semester labels Dec 17, 2023
@maxwai maxwai marked this pull request as ready for review December 17, 2023 15:06
byte-sized-emi
byte-sized-emi approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@byte-sized-emi byte-sized-emi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'd personally use query_as!() and #[derive(FromRow)]

For the logic side, I'm not sure, I don't know what exactly it's supposed to do. Will approve anyway

@maxwai maxwai merged commit d9c4df4 into main Dec 21, 2023
3 checks passed
@maxwai maxwai deleted the sql_methods branch December 21, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byte-sized-emi byte-sized-emi byte-sized-emi approved these changes

@marcelropos marcelropos Awaiting requested review from marcelropos

Assignees

@maxwai maxwai

Labels
Prio 1 ready for review PR is ready for review
Projects
None yet
Milestone
SS23
Development

Successfully merging this pull request may close these issues.

Add database methods
2 participants
@maxwai @byte-sized-emi