Remove timeout for wait-for command
#14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout for `wait-for` is 15 seconds. If service startup happens to take a long time then the subscription setup portion fails but it doesn't shutdown the container or anything. I think just setting the timeout to infinite is probably a good enough solution since it's likely that the emulator will startup eventually. A better solution could be to kill the emulator if it doesn't startup in time, but in that case I think you'd want the timeout to be configurable just in case someone has a REALLY slow startup.
|
In my docker compose it always failed the first time with: For me it would be really help if either the container stops, or that the timeout is longer/configurable. |
|
Ping on this again! |
|
Pinging this again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout for
wait-foris 15 seconds. If service startup happens to take a long time then the subscription setup portion fails but it doesn't shutdown the container or anything.I think just setting the timeout to infinite is probably a good enough solution since it's likely that the emulator will startup eventually. A better solution could be to kill the emulator if it doesn't startup in time, but in that case I think you'd want the timeout to be configurable just in case someone has a REALLY slow startup.