Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Grid Layout support #1095

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

Aiving
Copy link
Contributor

@Aiving Aiving commented Feb 6, 2025

No description provided.

@Aiving Aiving requested a review from marc2332 as a code owner February 6, 2025 11:47
@marc2332 marc2332 added enhancement 🔥 New feature or request layout 📐 Relate to layout labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 78.67804% with 100 lines in your changes missing coverage. Please review.

Project coverage is 74.95%. Comparing base (f3312ea) to head (feb0c82).

Files with missing lines Patch % Lines
crates/core/src/states/layout.rs 17.91% 55 Missing ⚠️
crates/torin/src/measure.rs 90.00% 20 Missing ⚠️
crates/torin/src/values/content.rs 0.00% 8 Missing ⚠️
crates/core/src/values/grid.rs 0.00% 7 Missing ⚠️
crates/core/src/values/content.rs 0.00% 4 Missing ⚠️
crates/torin/src/values/grid.rs 85.00% 3 Missing ⚠️
crates/torin/src/values/position.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   74.89%   74.95%   +0.05%     
==========================================
  Files         231      234       +3     
  Lines       28418    28868     +450     
==========================================
+ Hits        21284    21637     +353     
- Misses       7134     7231      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Aiving and others added 5 commits February 6, 2025 23:19
…attributes

feat: added docs for `grid_columns` and `grid_rows` attributes
feat: added ability to specify different horizontal and vertical spacings
fix: fixed (row/column)_span size calculation
@Aiving Aiving marked this pull request as draft February 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request layout 📐 Relate to layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants