fuse: initialize marfs config before mounting fuse #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the initialization of the marfs fuse context to occur before calling fuse_main(). The reason for this is to exit the fuse process before mounting the fuse filesystem when there are fatal errors. Once fuse_main() is called, exiting the daemon process leaves fuse mounted, causing ENOTCONN errors when accessing the mountpoint. However, if there are fatal errors in the configuration, there is no reason to even mount fuse at all. This commit also changes the errors in marfs_fuse_init() to output to stderr instead of using the LOG macro. This works because now the function always runs in the foreground so sending output to stderr works, and these errors should always be printed even if the binary is not compiled with logging enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the initialization of the marfs fuse context to occur before calling fuse_main(). The reason for this is to exit the fuse process before mounting the fuse filesystem when there are fatal errors. Once fuse_main() is called, exiting the daemon process leaves fuse mounted, causing ENOTCONN errors when accessing the mountpoint. However, if there are fatal errors in the configuration, there is no reason to even mount fuse at all.
This commit also changes the errors in marfs_fuse_init() to output to stderr instead of using the LOG macro. This works because now the function always runs in the foreground so sending output to stderr works, and these errors should always be printed even if the binary is not compiled with logging enabled.