rename id_format to source_id_format, refactor
#794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename configuration `auto_publish.tables.id_format` and `auto_publish.functions.id_format` fields from `id_format` to `source_id_format` fields. The `id_format` will continue to be supported (read) from the configuration, but it will be auto-converted to the new name on save. It is an error to have both in the same config file. * internal refactorings: consolidate PG-related utilities, rename a few vars, move PG errors to their own file.
upsicleclown
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename configuration
auto_publish.tables.id_formatandauto_publish.functions.id_formatfields fromid_formattosource_id_formatfields. Theid_formatwill continue to be supported (read) from the configuration, but it will be auto-converted to the new name on save. It is an error to have both in the same config file.idcolumn withauto_publish#682internal refactorings: consolidate PG-related utilities, rename a few vars, move PG errors to their own file.
This is partially made due to #790 (thanks @Binabh!) - and should be merged before that to make that PR easier.