Assigning default function type from spec #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some lingering issues from #161. I noticed that when I load a style where the type wasn't explicitly identified on a data driven style that it would default to
categorical
. Instead of this, if an uploaded style doesn't have atype
property this checks thefieldSpec
to determine what it should be.According to the style spec details on functions, any property that supports
interpolated
must be numeric and defaults toexponential
, and any property that is numeric and supports functions (checked elsewhere) must supportinterval
. I'm using that logic ingetFieldFunctionType
to determine which to assign, and it's worked on styles I've tested forexponential
,interval
, andcategorical