Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-driven styling #161

Merged
merged 10 commits into from
Oct 11, 2017
Merged

Add data-driven styling #161

merged 10 commits into from
Oct 11, 2017

Commits on Oct 1, 2017

  1. Add data-driven styling to editor 

    Builds off of the ZoomSpecField component with separate options for
handling data-driven properties. Reuses most of the zoom field
functionality with tweaks that I tried to keep as small as possible, and
the layout is based off of comments on the existing issue.
    @pjsier
    pjsier committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    e057fca View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2017

  1. Fix scss linter errors

    @pjsier
    pjsier committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    d731fb2 View commit details
    Browse the repository at this point in the history

  2. Remove default from data properties 

    It looks like default is not supported in this version of the style
spec, so pending the PR to update it I'm removing it as an input.
    @pjsier
    pjsier committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    9e52b0b View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Merge branch 'master' into feature/data-driven-styles

    @pjsier
    pjsier committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    bba7aa3 View commit details
    Browse the repository at this point in the history

  2. Re-add default field after style update

    @pjsier
    pjsier committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    2ffb3e7 View commit details
    Browse the repository at this point in the history

  3. Check for property-function support on data styles

    @pjsier
    pjsier committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    1d29f67 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2017

  1. Restrict data function types, reorder buttons 

    Checking the Mapbox style spec properties to see whether or not
exponential should be allowed as the property type, defaulting to
categorical which appears to work for either type. Also re-orders zoom
and data function buttons, aligning zoom right if data not supplied.
    @pjsier
    pjsier committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    148f64c View commit details
    Browse the repository at this point in the history

  2. Rename ZoomSpecField to FunctionSpecField

    @pjsier
    pjsier committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    4af7a71 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2017

  1. Fix default field bug

    @pjsier
    pjsier committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    b429202 View commit details
    Browse the repository at this point in the history

  2. Update mapbox deps, clarify data prop scope

    @pjsier
    pjsier committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    fa0067c View commit details
    Browse the repository at this point in the history