-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test additional code paths in java decoder #180
Merged
springmeyer
merged 16 commits into
maplibre:main
from
springmeyer:more-java-decoder-test-coverage
Jun 25, 2024
Merged
Test additional code paths in java decoder #180
springmeyer
merged 16 commits into
maplibre:main
from
springmeyer:more-java-decoder-test-coverage
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
springmeyer
commented
Jun 21, 2024
springmeyer
commented
Jun 21, 2024
msbarry
reviewed
Jun 22, 2024
msbarry
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few minor comments TIOLI
Thanks @msbarry! Replied to your comments. I'll merge this shortly. |
As intended & expected, this failed after pulling in #184:
Which is fixed by updating the test expectation in 7123203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do not fully test all these combinations:
This PR starts testing all those paths.
The code coverage changes are:
36%
to45%
64%
to85%
55%
to71%
In addition this PR includes:
Finally, this PR does not attempt to solve any bugs. Rather it finds, isolates, and writes tests harnesses to capture them in code. Once bugs are solved in the future it should be easy to update the tests accordingly.
TODO:
This PR uncovered a number of bugs that do not have open issues and did not have tests that hit them until now. So I need to create following issues to capture fixing these.