Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle fill field of view correctly #631

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Handle fill field of view correctly #631

merged 1 commit into from
Feb 4, 2025

Conversation

oscarlorentzon
Copy link
Member

Contribution

  • Use both horizontal and vertical field of view to ensure fill mode fills the viewport. Take aspect into account.

Test Plan

yarn build
yarn lint
yarn start

@oscarlorentzon
fix: handle fill fov correctly
dde58b7 
Take aspect and horizontal fov into account.
@oscarlorentzon oscarlorentzon added this to the v5.0.0 milestone Feb 4, 2025
@oscarlorentzon oscarlorentzon self-assigned this Feb 4, 2025
@oscarlorentzon oscarlorentzon merged commit 3850dff into main Feb 4, 2025
5 checks passed
@oscarlorentzon oscarlorentzon deleted the feature-fill-fov branch February 4, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarlorentzon @facebook-github-bot