Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate correct size for ImageLayer to avoid rescaling #3130

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Calculate correct size for ImageLayer to avoid rescaling #3130

merged 3 commits into from
Jan 9, 2024

Conversation

sebr72
Copy link
Contributor

@sebr72 sebr72 commented Dec 6, 2023

No description provided.

@sebr72 sebr72 closed this Dec 13, 2023
@sebr72 sebr72 reopened this Dec 13, 2023
@sebr72 sebr72 changed the title Disable automatic image rescaling Calculate correct size for ImageLayer to avoid rescaling Dec 14, 2023
@sebr72 sebr72 marked this pull request as ready for review January 9, 2024 10:34
sbrunner
sbrunner approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, should be squashed in 3 commits, than it can be merged :-)

core/src/main/java/org/mapfish/print/map/image/ImageLayer.java Outdated Show resolved Hide resolved
@sebr72 sebr72 merged commit 25fcb64 into master Jan 9, 2024
3 checks passed
@sebr72 sebr72 deleted the disable_image_rescaling branch January 9, 2024 14:03
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
@sbrunner sbrunner added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.31.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sebr72 @sbrunner