-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for printing to work with a shared volume (cloud environment) #25
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ca4941c
Adding Support for reading the tempfile from the disk
ritika-t-thakur-alb fc73783
Adding Support for reading the tempfile from the disk
ritika-t-thakur-alb d7cfbb4
Adding Support for reading the tempfile from the disk
ritika-t-thakur-alb 7cbe37d
Merge pull request #1 from tiago-s-vieira-alb/persistentVolume
tiago-s-vieira-alb e6d0d7c
Adding support for printing to work with a shared volume (cloud envir…
ritika-t-thakur-alb 725ee00
Adding support for printing to work with a shared volume (cloud envir…
ritika-t-thakur-alb 9ad615a
Adding support for printing to work with a shared volume (cloud envir…
ritika-t-thakur-alb a1ef30b
Merge branch 'mapfish:main' into persistentVolume
ritika-t-thakur-alb e21f03b
Merge branch 'persistentVolume' of https://github.com/tiago-s-vieira-…
ritika-t-thakur-alb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how does this work in a could environment - don’t they need to share a temp folder or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jodygarnett ,
I elaborated my documentation a bit more.
Answering your question: depending on the cloud environment, engineers an pick an option to share a volume between multiple instances and pass the path in the existing MAPFISH_PDF_FOLDER environment variable.
I have already updated installation.rst file with the documentation for MAPFISH_PDF_FOLDER.
I think the steps for creating a shared volume is not related with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jodygarnett, i think everything is done from our side.
Do you need more information?