Fixed qaseprite compile on Windows #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aseprite-msvc-dynamic-runtime.patch` is gone after its target `CMakeLists.txt` was merged into the qaseprite one. Check out the 1.0 tag to avoid future breakage in case changes are made to the plugin. Also use the new `update-submodules.sh` script to check out only the required submodules. The snap has been updated as well to use the 1.0 source archive.
bjorn
added a commit
that referenced
this pull request
Jan 23, 2025
The `aseprite-msvc-dynamic-runtime.patch` is gone after its target `CMakeLists.txt` was merged into the qaseprite one. Check out the 1.0 tag to avoid future breakage in case changes are made to the plugin. Also use the new `update-submodules.sh` script to check out only the required submodules. The snap has been updated as well to use the 1.0 source archive. (cherry picked from commit 9591005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aseprite-msvc-dynamic-runtime.patchis gone after its targetCMakeLists.txtwas merged into the qaseprite one in mapeditor/qaseprite@180451b.Check out the 1.0 tag to avoid future breakage in case changes are made to the plugin. Also use the new
update-submodules.shscript to check out only the required submodules.The snap has been updated as well to use the 1.0 source archive.