main #4
Open
main #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Editor / Remove wrong ERROR log message on multilingual records This type of errors were reported but are wrong on multilingual records: ``` 2024-05-16T10:45:08,952 ERROR [geonetwork.editor] - Element not found at ref = 554 2024-05-16T10:45:08,953 ERROR [geonetwork.editor] - Element not found at ref = 556 ``` Multilingual elements have reference like `_lang_EN_123` and are managed by `updatedLocalizedTextElement` method and the schema plugin. There is no need to search for them in the preprocess phase. * Update AjaxEditUtils.java
…nguages https://explore.transifex.com/geonetwork/core-geonetwork/ was updated for all those languages. This will facilitate installation of GeoNetwork in those places eg. https://geonetwork.napr.gov.ge/geonetwork Funded by Office International de l'Eau
…are the language and load SQL files for each languages if available.
* Improve tooltips for facet filter items * Improve tooltips for facet filter items in home page. GEMET facet is multilingual. --------- Co-authored-by: Francois Prunayre <[email protected]>
* Analytics services integration * Analytics services integration - add settings help * Analytics services integration - move configuration to config.properties * Analytics services integration - better name for web analytics service * Analytics improvements (#84) * Analytics services integration / Send events by protocol * Analytics services integration / Add example config for matomo. * Update web/src/main/webResources/WEB-INF/config.properties Co-authored-by: François Prunayre <[email protected]> * Test / Fix bean initialization Failing test were: ``` 15:47:17,320 [INFO] Results: 15:47:17,320 [INFO] Error: 7,320 [ERROR] Failures: Error: 7,320 [ERROR] AlternateLogoForPdfExportTest.whenGeneratingPdfWithPropertyNotSetSiteLogoIsUsed:114 Status expected:<200> but was:<400> Error: 7,321 [ERROR] AlternateLogoForPdfExportTest.whenGeneratingPdfWithPropertySetPdfLogoIsUsed:74 Status expected:<200> but was:<400> Error: 7,321 [ERROR] AlternateLogoForPdfExportTest.whenNotGeneratingPdfWithPropertySetSiteLogoIsUsed:93 Status expected:<200> but was:<400> Error: 7,321 [ERROR] Errors: Error: 7,321 [ERROR] FormatterApiIntegrationTest.testExec:97 » XPath Exception in extension functio. ``` --------- Co-authored-by: François Prunayre <[email protected]> Co-authored-by: Juan Luis Rodríguez Ponce <[email protected]>
…8164) Includes also prettier formatting fixes for other files
…n the map viewer is not enabled
…hen the map viewer is disabled.
Minimal update related to an open issue in Transifex
Bumps [com.google.guava:guava](https://github.com/google/guava) from 30.0-jre to 33.2.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.1.1 to 2.10.0. - [Release notes](https://github.com/xmlunit/xmlunit/releases) - [Changelog](https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md) - [Commits](xmlunit/xmlunit@v2.1.1...v2.10.0) --- updated-dependencies: - dependency-name: org.xmlunit:xmlunit-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.6.0 to 42.7.3. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.6.0...REL42.7.3) --- updated-dependencies: - dependency-name: org.postgresql:postgresql dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.owasp.esapi:esapi](https://github.com/ESAPI/esapi-java-legacy) from 2.4.0.0 to 2.5.4.0. - [Release notes](https://github.com/ESAPI/esapi-java-legacy/releases) - [Changelog](https://github.com/ESAPI/esapi-java-legacy/blob/develop/documentation/esapi4java-core-2.0-readme-crypto-changes.html) - [Commits](ESAPI/esapi-java-legacy@esapi-2.4.0.0...esapi-2.5.4.0) --- updated-dependencies: - dependency-name: org.owasp.esapi:esapi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.jayway.jsonpath:json-path](https://github.com/jayway/JsonPath) from 2.4.0 to 2.9.0. - [Release notes](https://github.com/jayway/JsonPath/releases) - [Changelog](https://github.com/json-path/JsonPath/blob/master/changelog.md) - [Commits](json-path/JsonPath@json-path-2.4.0...json-path-2.9.0) --- updated-dependencies: - dependency-name: com.jayway.jsonpath:json-path dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
The API accepts an optional parameter to retrieve the approved or the working copy versions.
…ister (#8176) * Register user / allow to select the group that wishes to register * Register user / API integration tests * Update web/src/main/webapp/WEB-INF/classes/org/fao/geonet/api/Messages.properties Co-authored-by: Jody Garnett <[email protected]> * Update web/src/main/webapp/WEB-INF/classes/org/fao/geonet/api/Messages_fre.properties Co-authored-by: Jody Garnett <[email protected]> * Update core/src/test/resources/org/fao/geonet/api/Messages.properties Co-authored-by: Jody Garnett <[email protected]> * Update core/src/test/resources/org/fao/geonet/api/Messages_fre.properties Co-authored-by: Jody Garnett <[email protected]> * Register user / disable group selection for profile Administrator * Register user / form improvements * Register user / surname not required * Register user / Update new account text * Update core/src/test/resources/org/fao/geonet/api/Messages_fre.properties Co-authored-by: François Prunayre <[email protected]> --------- Co-authored-by: Jody Garnett <[email protected]> Co-authored-by: François Prunayre <[email protected]>
While indexing, a number of log error can be reported: ``` 2024-06-18T17:11:21,679 ERROR [geonetwork] - Failed to get index field 'resourceTitleObject' value on '10.17600/14000100', caused by Document with id 10.17600/14000100 not found ``` This is due to either remote record links not present in index eg. DOI or to an empty index and document search returns no document at starts. It is triggered mainly in https://github.com/geonetwork/core-geonetwork/blob/main/web/src/main/webapp/xslt/common/index-utils.xsl#L141 but the `recordLink` field is currently not used in main UI. Related to e606996 and 20cc13b
Probably nobody is using this (?) which looks to be an experiment to get XML app and schema localization files from transifex. Also not sure about the source of the `exe` file it relies on.
Minor fixes in version number in tag, publish and md5.
Security configuration for GeoNetwork 4 deployed behing GeoNetwork 5 prototype using simple mode (ie. GN4 MUST not be exposed to intranet and internet). Authentication is managed by version 5 which check user credentials and create user in the database if needed. Then a JWT token is added to a header that version 4 checks. Related to: * JWT headers support #7899 * GeoNetwork 5 auth geonetwork/geonetwork#77 To enable the configuration, use: ```sh mvn jetty:run -Dgeonetwork.security.type=gn5 ```
…x filenames containing spaces. (#8581)
Prior to this fix, the swagger ui for applying site settings was not working.
Identified the media type that is being stored in the database. Instead of detecting if data is json or xml, instead base it on the media type for the event.
…ge source descriptions (#8595) angular.js?v=2e31720b368df88f570059d390b081d82fe9cf75:15697 Error: [linky:notstring] Expected string but received: [...
Update the "Creating group" section to match 4.2 user interface
…at are valid. (#8598) If the dates are not valid causes an error in the index, failing the search when the metadata is returned
* Check content-length of resource at url * Remove unnecessary throw * Fallback to InputStream.available() if content length is not found or smaller * Fallback maxUploadSize for unit tests * Fix default value always used * Remove content-length check as it cannot be trusted * Download file to a temp file to check size * Add back the content-length check as a preliminary check * Stream file instead of using temp file * Rollback for JCloud * Fix rollback for JCloud * Fix abstract store and implement jcloud rollback * Fix typo and remove unused import * Fix unit tests * Fix tests (mock response code) * Fix unit test, refactor, and add docs * Fix exception handling and use bounded input stream instead of custom input stream * Improvements * Add documentation * Rename exception * Remove unneeded changes * Update docs * Fix comment Co-authored-by: Ian <[email protected]> * Update exception handling * Update jcloud exception handling and comments * Add file header * Add comment * Fix whitespace --------- Co-authored-by: Ian <[email protected]>
* Audit user changes * Audit user changes - update translations * Add README.md file * Update UserAuditable model to track user address changes and add unit test for UserAuditable * Audit user changes - change to use Hibernate Envers due to Javers dependency conflict with Geotools for the picocontainer version * Audit user changes - update README.md documentation * Code formatting and styling * Update UsersApi to remove invalid user group assignment in the user update endpoint --------- Co-authored-by: Juan Luis Rodríguez <[email protected]>
Co-authored-by: david.blasby <[email protected]>
…port getting working copy records history. (#8153) * Update getRecordStatusHistory and getRecordStatusHistoryByType to support getting working copy records history. * Also include workflow/last api in the changes. * Update can edit to use non approved records when not specified.
Simples dates are common in many cases. Performance analysis showed that this can be a performance hotspot during harvesting. This is due to the design of UUIDMapper, which loads all metadata for a harvester for every new batch. This can not be easily changed, but we can improve the performance here, which also helps other code paths using this method. This change improves the performance of parseDate by removing as many string operations as possible. Doing this and some other minor optimisations, we can improve the performance so it is about 5x faster than the original.
* Fix jcloud content length is inaccurate * Remove extra space
… id. (#8266) Moved /api/sources/{type} to Moved /api/sources?type=type as it conflicted with /api/sources/{sourceIdentifier}
* Update getFilenameFromUrl to url decode the file name * Remove unneeded import * Add unit test
* Update to GeoTools 32.2
* Use `srv/api/me` endpoint (instead of old API) * Use session once connected.
* Metadata citation improvements: - BibTex: change data entry type to misc (data seems not valid: https://en.wikipedia.org/wiki/BibTeX\#Entry_types). - RIS: add support for PY (publication year), DA (publication date) LA (language) fields. * Metadata citation improvements: add option to save the citation to a file
…r the other languages (#8612)
* Restore metadata file store multiple files upload * Restore metadata file store multiple files upload - remove duplicated check * Restore metadata file store multiple files upload - initialize default value for singleUpload (overridable)
… check that is valid. (#8651)
…ile (#8650) * Update Transifex Dutch translations * Added Dutch translations, improved a few original ones * Update web/src/main/webapp/WEB-INF/classes/org/fao/geonet/api/Messages_dut.properties --------- Co-authored-by: Sander Schaminee <[email protected]>
… store (#8639) * Set the pasteZone for the fileupload directive * Set the pasteZone for the fileupload directive to null
Added translations of analog elements from the iso19139 metadata schema.
Ubuntu 20.04 will become unsupported on 2025-04. Update the images used in the Github Actions runners to one supported. actions/runner-images#11101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.