-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Mock and Test Setup #651
Open
ronilan
wants to merge
5
commits into
mapbox:master
Choose a base branch
from
ronilan:Refactor-Mock-and-Test-Setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2022
ronilan
force-pushed
the
Refactor-Mock-and-Test-Setup
branch
from
June 29, 2024 02:15
46fb6aa
to
0839a6a
Compare
ronilan
force-pushed
the
Refactor-Mock-and-Test-Setup
branch
5 times, most recently
from
June 29, 2024 07:07
4c57192
to
80b4aac
Compare
- mocking setup can be more easily used by automated tests and/or manually by developer. - mock modules moved to lib/mock. - mock modules are self contained and have a signature similar to that of other modules in the package. - simplified http mock to remove no longer needed interface. - modified http mock to support path style bucket access. - set http mock to work with default npg-mock-bucket bucket.
- separated s3 tests from build tests. - refactored fetch test and proxy-bcrypt test to work with refactored mock setup.
- set hosts of test apps to point to mock bucket. - added app1.1 - identical to app1 but using production and staging binary host option. - added app1.2 - identical to app1 but using explicit host, region, bucket options.
…is versa. Removed previous one. Fix CodeQL errors.
ronilan
force-pushed
the
Refactor-Mock-and-Test-Setup
branch
from
June 30, 2024 21:28
80b4aac
to
7e50d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request refactors the S3 mocking setup (see: #540) simplifying implementation, separates the S3 tests from the build tests, introduces test apps using alternative bucket specification (see: #576) and production/staging hosts (see: #533) and enables easy switch between mock bucket and real bucket (given status of: #613).
This pull request comes "on top" of (i.e. includes changes from) #648, #649, #650.
Change
Code
lib/mock
.npg-mock-bucket
bucket.Testing
node_pre_gyp_mock_s3
to true will run them against the mock (see: repo CI).node_pre_gyp_mock_s3
.AWS_ACCESS_KEY_ID
,AWS_SECRET_ACCESS_KEY
.npm run bucket {name-of-your-us-east-1-bucket}
node_pre_gyp_mock_s3
to true.npm run bucket
us-east-1
also works but switch is more work.npm run coverage
differ depending on what bucket is used (real s3 or mock).Tests