Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Introduce descender, ascender in glyphMetrics + Fix fonts dis-alignment #15676

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

zmiao
Copy link
Contributor

@zmiao zmiao commented Sep 19, 2019

mapbox/node-fontnik#160 will introduce new metadata ascender and descender, it would help fix issue mapbox/mapbox-gl-js#191. This pr only covers reading data from pbf and partially replacing hard coded baseline for fixing mixed fonts dis-alignment.
Render test: mapbox/mapbox-gl-js#8781

src/mbgl/text/glyph.hpp Outdated Show resolved Hide resolved
src/mbgl/text/glyph_pbf.cpp Show resolved Hide resolved
src/mbgl/text/glyph_pbf.cpp Outdated Show resolved Hide resolved
src/mbgl/text/glyph_pbf.cpp Outdated Show resolved Hide resolved
src/mbgl/text/shaping.cpp Outdated Show resolved Hide resolved
src/mbgl/text/shaping.cpp Outdated Show resolved Hide resolved
src/mbgl/text/shaping.cpp Outdated Show resolved Hide resolved
src/mbgl/text/shaping.cpp Outdated Show resolved Hide resolved
@zmiao zmiao force-pushed the zmiao-fix-mixed-fonts-disalignment branch from bae131e to 70942a2 Compare September 26, 2019 11:16
src/mbgl/text/glyph_pbf.cpp Outdated Show resolved Hide resolved
src/mbgl/text/shaping.cpp Outdated Show resolved Hide resolved
@zmiao zmiao force-pushed the zmiao-fix-mixed-fonts-disalignment branch 3 times, most recently from 7a8a714 to 32dd8e6 Compare October 2, 2019 08:47
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

src/mbgl/text/glyph_manager.cpp Outdated Show resolved Hide resolved
@zmiao zmiao force-pushed the zmiao-fix-mixed-fonts-disalignment branch from dce9656 to 20f73e7 Compare October 4, 2019 20:20
@zmiao zmiao force-pushed the zmiao-fix-mixed-fonts-disalignment branch from 20f73e7 to da7a67b Compare October 6, 2019 16:48
@chloekraw chloekraw added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Oct 10, 2019
@jseppi jseppi self-assigned this Oct 28, 2019
@tmpsantos tmpsantos removed their request for review April 22, 2020 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants