Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Commit

Permalink
[tests] Bump GL JS to run render test for #15139
Browse files Browse the repository at this point in the history
  • Loading branch information
tmpsantos committed Jul 19, 2019
1 parent fe9d463 commit 1aa4776
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 1 deletion.
2 changes: 1 addition & 1 deletion mapbox-gl-js
Submodule mapbox-gl-js updated 54 files
+8 −1 CHANGELOG.md
+1 −1 docs/components/api-navigation.js
+1 −1 docs/components/example.js
+12 −5 docs/components/page_shell.js
+0 −128 docs/data/plugins.js
+2 −1 docs/pages/example/3d-buildings.html
+2 −1 docs/pages/example/3d-extrusion-floorplan.html
+6 −4 docs/pages/example/add-3d-model.html
+2 −1 docs/pages/example/custom-style-layer.html
+2 −1 docs/pages/example/dancing-buildings.html
+2 −2 docs/pages/example/forward-geocode-custom-data.html
+3 −3 docs/pages/example/map-tiles.html
+1 −1 docs/pages/example/map-tiles.js
+2 −2 docs/pages/example/mapbox-gl-geocoder-accept-coordinates.html
+2 −2 docs/pages/example/mapbox-gl-geocoder-custom-render.html
+2 −2 docs/pages/example/mapbox-gl-geocoder-limit-region.html
+2 −2 docs/pages/example/mapbox-gl-geocoder-outside-the-map.html
+2 −2 docs/pages/example/mapbox-gl-geocoder-with-flyto.html
+2 −2 docs/pages/example/mapbox-gl-geocoder-with-language.html
+2 −2 docs/pages/example/mapbox-gl-geocoder.html
+2 −2 docs/pages/example/point-from-geocoder-result.html
+5 −1 docs/pages/plugins.js
+1 −4 docs/pages/style-spec.js
+4 −4 package.json
+2 −1 src/data/bucket.js
+43 −5 src/data/bucket/circle_bucket.js
+34 −16 src/data/bucket/fill_bucket.js
+34 −16 src/data/bucket/line_bucket.js
+4 −2 src/data/load_geometry.js
+65 −3 src/render/draw_circle.js
+52 −1 src/style-spec/reference/v8.json
+2 −0 src/style-spec/style-spec.js
+3 −0 src/style-spec/types.js
+5 −2 src/style/style_layer/circle_style_layer.js
+9 −2 src/style/style_layer/circle_style_layer_properties.js
+5 −2 src/style/style_layer/fill_style_layer.js
+9 −2 src/style/style_layer/fill_style_layer_properties.js
+2 −0 src/style/style_layer/line_style_layer_properties.js
+10 −2 src/ui/control/navigation_control.js
+5 −1 src/ui/map.js
+10 −6 src/util/actor.js
+5 −0 src/util/ajax.js
+3 −0 src/util/mapbox.js
+ test/integration/render-tests/circle-sort-key/literal/expected.png
+81 −0 test/integration/render-tests/circle-sort-key/literal/style.json
+ test/integration/render-tests/fill-sort-key/literal/expected.png
+93 −0 test/integration/render-tests/fill-sort-key/literal/style.json
+ test/integration/render-tests/line-sort-key/literal/expected.png
+69 −0 test/integration/render-tests/line-sort-key/literal/style.json
+ test/integration/render-tests/regressions/mapbox-gl-native#15139/expected.png
+72 −0 test/integration/render-tests/regressions/mapbox-gl-native#15139/style.json
+11 −3 test/unit/data/load_geometry.test.js
+9 −0 test/unit/util/mapbox.test.js
+1 −1 vendor/docs-page-shell/page-shell-script.js
5 changes: 5 additions & 0 deletions platform/android/scripts/generate-style-code.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ const ejs = require('ejs');
const spec = require('../../../scripts/style-spec');
const _ = require('lodash');

// FIXME: https://github.com/mapbox/mapbox-gl-native/issues/15008
delete spec.layout_circle["circle-sort-key"]
delete spec.layout_line["line-sort-key"]
delete spec.layout_fill["fill-sort-key"]

require('../../../scripts/style-code');

// Specification parsing //
Expand Down
5 changes: 5 additions & 0 deletions platform/darwin/scripts/generate-style-code.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ const suffix = 'StyleLayer';

let spec = _.merge(require('../../../scripts/style-spec'), require('./style-spec-overrides-v8.json'));

// FIXME: https://github.com/mapbox/mapbox-gl-native/issues/15008
delete spec.layout_circle["circle-sort-key"]
delete spec.layout_line["line-sort-key"]
delete spec.layout_fill["fill-sort-key"]

// Rename properties and keep `original` for use with setters and getters
_.forOwn(cocoaConventions, function (properties, kind) {
_.forOwn(properties, function (newName, oldName) {
Expand Down
3 changes: 3 additions & 0 deletions platform/node/test/ignores.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@
"render-tests/remove-feature-state/vector-source": "https://github.com/mapbox/mapbox-gl-native/issues/12413",
"render-tests/regressions/mapbox-gl-js#8026": "skip - js specific",
"render-tests/fill-extrusion-geometry/linestring": "https://github.com/mapbox/mapbox-gl-native/pull/14240",
"render-tests/circle-sort-key/literal": "https://github.com/mapbox/mapbox-gl-native/issues/15008",
"render-tests/fill-sort-key/literal": "https://github.com/mapbox/mapbox-gl-native/issues/15008",
"render-tests/line-sort-key/literal": "https://github.com/mapbox/mapbox-gl-native/issues/15008",
"query-tests/remove-feature-state/default": "https://github.com/mapbox/mapbox-gl-native/issues/12413",
"query-tests/fill-extrusion/base-in": "https://github.com/mapbox/mapbox-gl-native/issues/13139",
"query-tests/fill-extrusion/box-in": "https://github.com/mapbox/mapbox-gl-native/issues/13139",
Expand Down
5 changes: 5 additions & 0 deletions scripts/generate-style-code.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ const ejs = require('ejs');
const spec = require('./style-spec');
const colorParser = require('csscolorparser');

// FIXME: https://github.com/mapbox/mapbox-gl-native/issues/15008
delete spec.layout_circle["circle-sort-key"]
delete spec.layout_line["line-sort-key"]
delete spec.layout_fill["fill-sort-key"]

require('./style-code');

function parseCSSColor(str) {
Expand Down

0 comments on commit 1aa4776

Please sign in to comment.