Updated comment for LngLatBounds to discuss the range of valid input for this method in order to reflect in the API docs on site #13137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been edited in both lng_lat.js and lng_lat_bounds.js but from tests it only seems lng_lat.js is needed but cross posting for consistency just in case.
|
@stepankuzmin Hey Stepan! When you have time would you be able to review this PR? Absolutely no rush! Also I'm getting a failure in the CircleCi test unit, but it's not related to my changes. Thanks for your time! |
|
Moved this change to the internal version of the repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parallel with a customer request about fitbounds, I've added a description to the LngLatBounds API comment to specify the limitations of the longitude and latitude ranges so it can be reflected in the site's API documentation.
This has been edited in both lng_lat.js and lng_lat_bounds.js since the original comment appeared in both locations, however from tests it only seems the comment in lng_lat.js actually made a change to the generated API docs.
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.