Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.0-beta.2 #12879

Merged
merged 44 commits into from
Sep 5, 2023
Merged

v3.0.0-beta.2 #12879

merged 44 commits into from
Sep 5, 2023

Conversation

mourner
Copy link
Member

@mourner mourner commented Sep 5, 2023

See #12829 for more information about the v3 release. Changes since v3.0.0-beta.1:

✨ Features and improvements

  • Improve performance of fill extrusion ground flood light & ambient occlusion effect.
  • Improve terrain sampling accuracy.
  • Add style.import.load event to track loading of imported style fragments and ensure style.load is only called once per style.
  • Allow adding symbol layers to styles with imports if they don't have a glyphs endpoint specified (falling back to a default Mapbox endpoint).
  • Make sure API methods that return features or layers don't leak internals of imported styles.
  • Remove optimizeForTerrain map option (layer rendering on terrain is always optimized now).

Bug fixes 🐞

  • Fix accuracy of atmosphere gradient when rendering globe.
  • Fix a bug where circle & heatmap layers rendered incorrectly in some situations.
  • Fix a bug where model colors weren't always re-evaluated when light properties changed.
  • Fix a bug where calling setStyle when using the Standard style failed.
  • Fix a bug where map.removeSource didn't work properly with the Standard style.
  • Fix a bug with map.setLayoutProperty not working on a custom layer.
  • Fix a bug with hillshade rendering on terrain when combined with new light API.
  • Fix a bug where fill extrusion flood light effect sometimes caused visible seams between tiles.
  • Fix a bug with horizon placement when map padding is used.

akoylasar and others added 30 commits September 4, 2023 14:40
@akoylasar @mourner
[MAPS3D-934][MAPS3D-967] Reduce segment overlap to avoid overdraw, fi…
d9e7361 
…x bug (internal-669)

* [MAPS3D-934][MAPS3D-967] reintroduce optimisation and fix bugs

* lint

* add missing clamp for cosHalfAngle
@dependabot @mourner
Bump word-wrap from 1.2.3 to 1.2.5 (internal-678)
2d26a42 
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexey-romanov @mourner
[MAPS3D-899] support floating point textures for DEM (internal-607)
977053e 
* support floating point textures for DEM
* fix terrain DEM linear interpolation
* new test for checking interpolation quality with 256px DEM tile
* Remove TERRAIN_DEM_NEAREST_FILTER optimization
@endanke @mourner
Add more measure light tests (internal-680)
7d7d0e8 
* Add render test for zoom based light values and brightness in model layer properties

* Add render test for zoom out after light configuration change
@endanke @mourner
Add check for model color to trigger bucket re-evaluation (internal-685)
bc03ebb 
* Add check for model color to trigger bucket re-evaluation

* Use calculated brightness in model bucket
@stepankuzmin @mourner
Add Style Spec License (internal-684)
a02c71b
@stepankuzmin @mourner
Fix Windows prepare job in CircleCI (internal-691)
ab90aac 
* Update Windows Orb

* Use nvm instead of Chocolately

* Skip render test in WebGL1
@dependabot @mourner
Bump puppeteer-core from 21.0.1 to 21.0.3 (internal-690)
a2307c6 
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 21.0.1 to 21.0.3.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-core-v21.0.1...puppeteer-core-v21.0.3)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@aleksigron @mourner
[MAPS3D-776] Port shadow render tests from native (internal-643)
28fda4b 
* Add allowed range to style property directional light direction
* Render translucent landmarks with two-pass method
* Did some refactoring to better reuse intermediate calculation results
* Port render tests
* Update landmark-shadows-terrain expectation
* Ignore flaky render test
@dependabot @mourner
Bump @rollup/plugin-commonjs from 25.0.3 to 25.0.4 (internal-688)
224babe 
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 25.0.3 to 25.0.4.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v25.0.4/packages/commonjs)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-commonjs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump rollup from 3.27.2 to 3.28.0 (internal-687)
7b18b1b 
Bumps [rollup](https://github.com/rollup/rollup) from 3.27.2 to 3.28.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.27.2...v3.28.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexey-romanov @mourner
[GLJS-460] circle layer: respect orthographic camera lerp (internal-692)
d2d7b13 
* handle camera perspective<->orthographic projection lerp for circle layer
* add orthographic camera projection circle layer test
@stepankuzmin @mourner
Bump sdk-support to v3 for new fill-extrusion properties (internal-672)
76bbbde
@dependabot @stepankuzmin @mourner
Bump the dependencies group with 2 updates (internal-693)
891e839 
* Bump the dependencies group with 2 updates

Bumps the dependencies group with 2 updates: [@loaders.gl/3d-tiles](https://github.com/visgl/loaders.gl) and [@loaders.gl/core](https://github.com/visgl/loaders.gl).

Updates `@loaders.gl/3d-tiles` from 3.4.9 to 3.4.11
- [Changelog](https://github.com/visgl/loaders.gl/blob/v3.4.11/CHANGELOG.md)
- [Commits](visgl/loaders.gl@v3.4.9...v3.4.11)

Updates `@loaders.gl/core` from 3.4.9 to 3.4.11
- [Changelog](https://github.com/visgl/loaders.gl/blob/v3.4.11/CHANGELOG.md)
- [Commits](visgl/loaders.gl@v3.4.9...v3.4.11)

---
updated-dependencies:
- dependency-name: "@loaders.gl/3d-tiles"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: "@loaders.gl/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update package.json

* bump yarn.lock

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stepan Kuzmin <[email protected]>
@akoylasar @mourner
[MAPS3D-996] Reduce vertex buffer size in flood lighting and ground A…
234caaf 
…O when rounded edges are enabled to improve performance (internal-683)

* reduce vertex count in flood light and ground AO geometry when rounded edges are enabled

* update expectation, ignore test on webgl1 node

* lint and set allowed threshold for failing test

* optimise only for zoom 15 and 16

* update expectation

* update expectations

* slightly raise threshold

* Empty commit to trigger CI
@stepankuzmin @mourner
Downgrade @loaders.gl (internal-697)
7f8734a
@akoylasar @mourner
raise render test threshold (internal-699)
211d376
@alexey-romanov @mourner
[MAPS3D-993] fix atmosphere gradient in globe mode (internal-695)
6d46f7d 
Use highp precision qualifier for gradient lerps.
@stepankuzmin @mourner
Check for Workers on WorkerPool.release (internal-698)
63bab81 
* Add check for Workers on WorkerPool.release
@stepankuzmin @mourner
Fix Style.removeSource (internal-696)
3b345ab
@stepankuzmin @mourner
Add the style.import.load event (internal-694)
2086d75 
* Add `style.import.load` event

---------

Co-authored-by: Volodymyr Agafonkin <[email protected]>
@dependabot @mourner
Bump @rollup/plugin-node-resolve from 15.1.0 to 15.2.0 (internal-703)
6f2ac3a 
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 15.1.0 to 15.2.0.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/node-resolve-v15.2.0/packages/node-resolve)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-node-resolve"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump postcss from 8.4.27 to 8.4.28 (internal-704)
0811e88 
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.28.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.27...8.4.28)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump puppeteer-core from 21.0.3 to 21.1.0 (internal-705)
f3e5f84 
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 21.0.3 to 21.1.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-core-v21.0.3...puppeteer-core-v21.1.0)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump eslint-plugin-jsdoc from 46.4.6 to 46.5.0 (internal-708)
52314e3 
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 46.4.6 to 46.5.0.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](gajus/eslint-plugin-jsdoc@v46.4.6...v46.5.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump eslint-plugin-import from 2.28.0 to 2.28.1 (internal-706)
9a02b16 
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.28.0 to 2.28.1.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.28.0...v2.28.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump stylelint from 15.10.2 to 15.10.3 (internal-707)
e2d7ecd 
Bumps [stylelint](https://github.com/stylelint/stylelint) from 15.10.2 to 15.10.3.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@15.10.2...15.10.3)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stepankuzmin @mourner
Fix changing CustomLayer visibility with setLayoutProperty (internal-…
4b2f5bf 
…709)

* Check for CustomLayer on changing layer visibility
@stepankuzmin @mourner
Fallback to the default font stack if none is specified (internal-701)
8288ae7 
* Fallback to the default font stack if none is specified

* Skip the validation for missing `glyphs` property if the style has imports

---------

Co-authored-by: Volodymyr Agafonkin <[email protected]>
@stepankuzmin @mourner
Remove the access to the import internals from the public API (intern…
4199a0c 
…al-710)

* Remove the access to the import internals from the public API
dependabot bot and others added 14 commits September 4, 2023 14:46
@dependabot @mourner
Bump @babel/core from 7.22.10 to 7.22.11 (internal-715)
6b21156 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.10 to 7.22.11.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.11/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump rollup from 3.28.0 to 3.28.1 (internal-717)
8678567 
Bumps [rollup](https://github.com/rollup/rollup) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.28.0...v3.28.1)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump puppeteer-core from 21.1.0 to 21.1.1 (internal-718)
0dba035 
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 21.1.0 to 21.1.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-core-v21.1.0...puppeteer-core-v21.1.1)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump @rollup/plugin-node-resolve from 15.2.0 to 15.2.1 (internal-719)
e8779f3 
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 15.2.0 to 15.2.1.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/node-resolve-v15.2.1/packages/node-resolve)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-node-resolve"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump @babel/eslint-parser from 7.22.10 to 7.22.11 (internal-716)
92c0249 
Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.22.10 to 7.22.11.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.11/eslint/babel-eslint-parser)

---
updated-dependencies:
- dependency-name: "@babel/eslint-parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexey-romanov @mourner
[MAPS3D-878] remove optimizeForTerrain option (internal-700)
dbb1c30 
* remove optimizeForTerrain option
* fix hillshade rendering for draped mode
@stepankuzmin @mourner
Disallow using fully qualified IDs in the public APIs (internal-721)
54ed0c2 
* Disallow using fully qualified IDs in the public APIs
@alexey-romanov @mourner
[MAPS3D-798] fix fill extrusion pattern precision for Mali (internal-…
ff8ba3c 
…724)
@mpulkki-mapbox @mourner
Add render tests for partial FE bucket rendering (internal-722)
6a0b87f
@jtorresfabra @mourner
Define scope for manually added layers (internal-726)
3dcc40a
@akoylasar @mourner
[MAPS3D-1021] Fix seams visible on tile borders caused by flood light…
e5fb909 
…ing in draped mode (internal-711)

* Alleviate seams for flood light only in drape mode

* lint

* render test

* optimisation (internal-714)

* some clean up and review fixes

* minor

* use quad
@alexey-romanov @mourner
[MAPS3D-1001] fix horizon line calculation in case of padding (intern…
fbc5533 
…al-727)
@mourner
update ignores
0a22982
@mourner
v3.0.0-beta.2
93ef856
@mourner mourner added the skip changelog Used for PRs that do not need a changelog entry label Sep 5, 2023
@mourner mourner requested a review from a team as a code owner September 5, 2023 15:26
@mourner mourner merged commit 93ef856 into main Sep 5, 2023
7 checks passed
@mourner mourner deleted the v3-beta2 branch September 5, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mourner @stepankuzmin @akoylasar @alexey-romanov @endanke @aleksigron @mpulkki-mapbox @jtorresfabra