Allow updating an image before it loads or fails to load (#12992) (h/t …

…@maciejmatu)

Co-authored-by: maciejmatu <[email protected]>

src/source/image_source.js

@@ -227,7 +227,7 @@ class ImageSource extends Evented implements Source {
      * });
      */
     updateImage(options: {url: string, coordinates?: Coordinates}): this {
-        if (!this.image || !options.url) {
+        if (!options.url) {
             return this;
         }
         if (this._imageRequest && options.url !== this.options.url) {

test/unit/source/image_source.test.js

@@ -55,6 +55,12 @@ test('ImageSource', (t) => {
         img.onload();
         img.data = new Uint8Array(req.response);
     };
+    const respondNotFound = () => {
+        const req = requests.shift();
+        req.setStatus(404);
+        req.onerror();
+        req.response = new ArrayBuffer(1);
+    };
     t.stub(browser, 'getImageData').callsFake(() => new ArrayBuffer(1));
 
     t.test('constructor', (t) => {
@@ -256,5 +262,22 @@ test('ImageSource', (t) => {
         t.end();
     });
 
+    t.test('updates image before first image was loaded', (t) => {
+        const source = createSource({url : '/notfound.png'});
+        const map = new StubMap();
+        const spy = t.spy(map._requestManager, 'transformRequest');
+        const errorStub = t.stub(console, 'error');
+        source.onAdd(map);
+        respondNotFound();
+        t.ok(errorStub.calledOnce);
+        t.notOk(source.image);
+        source.updateImage({url: '/image2.png'});
+        respond();
+        t.ok(spy.calledTwice);
+        t.equal(spy.getCall(1).args[0], '/image2.png');
+        t.equal(spy.getCall(1).args[1], 'Image');
+        t.end();
+    });
+
     t.end();
 });