Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodeps: Support deep nested structures for mapMultiRowFields #77

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ocordeiro
Copy link

Add Support to deep nested structures for mapMultiRowFields
without new dependencies.

@coveralls
Copy link

coveralls commented Nov 11, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d788ab1 on ocordeiro:master into 886c135 on maoberlehner:master.

@geoidesic
Copy link
Collaborator

@ocordeiro Please update / add tests for this PR.

@geoidesic
Copy link
Collaborator

geoidesic commented Jun 15, 2020

This doesn't seem to be backwards compatible btw. I.e. I've tried it with existing code that works with mapMultiRowFields and that breaks with this implementation. Specifically, it doesn't allow the final end node to be an array (some elements like select require the model to be an array) – if it is an array then it assumes that array is intended to be part of nested iteration and will iterate into that array. So as far as I can tell this cannot be used with such elements, which makes this largely useless. I've tried to implement this in various ways and I can't see that it's doing anything useful. @ocordeiro perhaps it would help if you could show a usage example, obrigado! The ball is in your court.

@ocordeiro
Copy link
Author

This doesn't seem to be backwards compatible btw. I.e. I've tried it with existing code that works with mapMultiRowFields and that breaks with this implementation. Specifically, it doesn't allow the final end node to be an array (some elements like select require the model to be an array) – if it is an array then it assumes that array is intended to be part of nested iteration and will iterate into that array. So as far as I can tell this cannot be used with such elements, which makes this largely useless. I've tried to implement this in various ways and I can't see that it's doing anything useful. @ocordeiro perhaps it would help if you could show a usage example, obrigado! The ball is in your court.

added tests and synced with latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants