Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for issue #43 (Shortcut for multiple object properties) #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anikolaev
Copy link

Changes for issue #43 :

  • add mapObjectFields() to add object properties using template e.g. 'property.*' or '*'

@coveralls
Copy link

coveralls commented Oct 17, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 58eca7f on anikolaev:object-prop into 65842ca on maoberlehner:master.

@maoberlehner
Copy link
Owner

@anikolaev thank you for your work! I'll take a closer look the next couple of days. Sorry for the delay, I've got a lot of stuff to do currently.

@mariobalca
Copy link

Hey @maoberlehner, sorry to bother but this actually seems to be the perfect solution for some difficulties that I'm having using vuex-map-fields, do you have an estimation of when is this getting merged/released? And thank you for your work with this package, it's really helpful!

@code-yo
Copy link

code-yo commented Dec 16, 2018

@maoberlehner thanks for the great package it's very simplify my way in project. But I have the problem with fields that does not exist. Could you please review and merge pull-request?

@maoberlehner maoberlehner changed the base branch from master to feature/property-default-values December 17, 2018 05:49
@maoberlehner maoberlehner changed the base branch from feature/property-default-values to dev December 17, 2018 05:50
@maoberlehner maoberlehner changed the base branch from dev to master December 17, 2018 07:19
Copy link
Owner

@maoberlehner maoberlehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the yarn.lock file. Thx!

Additionally, I find it confusing that the API of mapObjectFields() and mapFields() is pretty much the same. I'd find it hard to explain that in the documentation. Btw: please also update the documentation in the README.md ;)

I'd love to have the functionality from mapObjectFields() merged into mapFields() if this is possible?

Thanks for the great work so far!

@anikolaev
Copy link
Author

@maoberlehner One of previous yarn versions added these integrity lines. Now they only add them for changed modules. Reverted.

Yes, I think integration of mapObjectFields() into mapFields() may work but it needs to be investigated. I see at least one limitation - you cannot have keys with asterisks (*) in this case but they are probably rarely used. Same for empty keys. Maybe mapMultiRowFields() also could be integrated (something like ...mapFields({ users: 'users[]'})). Unfortunately I am not sure I can check it now. Same for the documentation.

@Exalyn
Copy link

Exalyn commented Jan 14, 2020

Hi.
I'm using your work and i found this, any update or news about this feature ?
I have a user form with a separate address component including billing and shipping address, so mapping all fields is kinda long and not very good.

@frankievx
Copy link

Can someone revert the yarn.lock?

@geoidesic
Copy link
Collaborator

@anikolaev looks like there are failing tests here. Can you address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants