Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #360 - return void instead of promise in preload.mediadevices-shim #361

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: #360 - return void instead of promise in preload.mediadevices-shim #361

merged 1 commit into from
Oct 23, 2023

Conversation

vishnukaushik
Copy link
Contributor

Fixes #360
Changed the code to return void instead of Promise in preload.mediadevices-shim

@vishnukaushik
Copy link
Contributor Author

@manusa Could you please take a look at this PR when you get a chance?
I need to get maintainers' approval to get the workflow started.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

manusa
manusa approved these changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 321786c into manusa:main Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preload.mediadevices-shim: Promise returned in function argument where a void return was expected.
2 participants
@vishnukaushik @manusa