-
Notifications
You must be signed in to change notification settings - Fork 45
refact(async-vfs): move to tokio #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hi @Fredrik-Reinholdsen sorry for the ping! I'm trying to move your async-vfs to tokio, but the ci failed. But I tried in windows. Do you have some idea? |
Hi there, thanks for the PR. Just a quick heads up: I have to admit I don't feel confident enough in my expertise with async rust in general and tokio in particular to adequately review and support a tokio variant. I may even have to sunset the current async-std variant. It might be worth looking into forking this project into a separate |
Quick note on the CI failing: It looks like the lock file has a different version, cf. https://github.com/manuel-woelker/rust-vfs/actions/runs/14877441640/job/41777455425?pr=74 Things to try:
|
Hi Manuel, Agree that the lockfile is wrong. |
@attila-lin The reason has to do with the checked out lockfile. Lockfile version 4 was stabilized in Rust 1.78, and the minimum required Rust version is 1.63 which is significantly older. You could try just manually changing the version in the lockfile to 3 instead of 4 and see if that works, because they should be backwards compatible. The other option would be to increase the, but that I do not think is a great idea because it would be a significant jump, and it should be possible without this. |
I got it. Let me try. |
as
async-std
has been discontinued. move to tokio