Use semver instead of fixed minor ver for rust-embed #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! AFAICT this shouldn't cause any issues. |
|
Looks like this this causes issues in rust-embed-utils when building with Rust 1.40. I'm wondering if there's a clever way to keep building with an "old" rust-embed version, while allow more flexibility with regards to the version downstream projects use. Although it might be time to lift the minimum required Rust version... |
|
Sorry for the troubles - I looked through docs but wasn't able to find any mechanism to force the version to lower for tests in this repo, other than lock file which shouldn't be committed for libraries. I'm new to rust though so could be missing something |
|
No problem, I'll have a look to figure out how to proceed on this. Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes explicit dependency on rust-embed-impl, which is a transitive dependency of rust-embed (I couldn't find any references to it in this crate).
I am trying to use rust-vfs with a newer version of rust-embed but the
6.3.*specifier prevents this. Presumably this was meant to be a minimum version number, not hard lock, so I tried to change to the semver syntax for that.