Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Editor: add example config files #512

Merged
merged 8 commits into from
Jul 17, 2024

Conversation

miltondp
Copy link
Contributor

@miltondp miltondp commented Jul 9, 2024

No description provided.

@AppVeyorBot
Copy link

AppVeyor build 1.0.339 for commit 33e2bdf is now complete.

Found 51 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think ai_revision-config.yaml and ai_revision-prompts.yaml belong under content, which should remain primarily content that composes the manuscript.

I think ci or less likely build would be a more appropriate directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Daniel. I'll talk with @vincerubinetti and Faisal about this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dhimmel, agreed; per your suggestion we've moved the config files to ci rather than content.

@miltondp miltondp marked this pull request as ready for review July 16, 2024 03:51
@miltondp
Copy link
Contributor Author

@dhimmel this PR is ready to be merged. @vincerubinetti maybe you can start testing this now.


Input paragraph: {{ content }}

Proofread paragraph:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing final newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@dhimmel dhimmel merged commit 2d4652d into manubot:main Jul 17, 2024
1 check passed
@vincerubinetti
Copy link
Collaborator

@dhimmel note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version. That will be need to be updated as well. It also seems like a new PIPY version should be pushed, and that rootstock should be based off of PYPI, but I'll leave that to you.

@miltondp
Copy link
Contributor Author

@dhimmel note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version. That will be need to be updated as well. It also seems like a new PIPY version should be pushed, and that rootstock should be based off of PYPI, but I'll leave that to you.

From this, I understand that following the instructions to create a new Manubot-based manuscript (fork of this repo) and run the AI Editor would fail, right?

@dhimmel
Copy link
Member

dhimmel commented Jul 20, 2024

note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version.

This pull request should have incremented the manubot version for manubot ai-revision --config-directory support. My bad for not noting that during the review.

#513 upgrades the manubot version used in rootstock and should resolve the problem.

I see the following as separate points as separate from the cause of this issue (and separate from eachother):

  • whether rootstock installs the latest manubot version or a pinned version (I strongly prefer pinned here)
  • whether the manubot package is installed from GitHub or PyPI

@miltondp miltondp deleted the ai-revision-updated branch July 24, 2024 03:32
ctessum pushed a commit to uiceds/rootstock that referenced this pull request Sep 10, 2024
merges manubot#512

Co-authored-by: Faisal Alquaddoomi <[email protected]>
msubirana pushed a commit to pivlab/annual_review_of_biomedical_data_science that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants