-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer ai-editor documentation to dedicated repo #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Wondering if @vincerubinetti you would like us to hold off on merging since this is still marked as draft?
yes, please hold off on merging. We still need to work on the documentation in the editor repo some more |
@vincerubinetti do you think the USAGE.md here has gotten too long and complex? The AI workflow is part of this repo, so I'm wondering about the motivation for moving the documentation. I'm not against it but want to understand your thought process. about how we'll manage these. Making sure @miltondp sees this too. |
Milton is aware; it may have been his suggestion iirc. I think the idea is just that the AI editor is a somewhat complex and separate thing. As a comparison, you do have detailed instructions about how citations work, which could perhaps be deferred to documentation in the python package for collocation. But in that case, citations are really the bread and butter of Manubot, whereas less people would use the AI editor. Perhaps more importantly, since the AI editor is still early in its development and changing a lot, it might make for a cleaner commit history here. While developing/maintaining lab-website-template (a similar case to rootstock, where it's not an installable "package" but rather a template), I try to be wary of frequently changing files, as merging in upstream updates can be a painful process, especially for less technical users. I don't feel strongly about this though. The writing I added could stand as is, and we could keep the stuff I removed. |
Thanks, that's helpful. If the |
The team working on the Manubot AI Editor decided it would make more sense to have its documentation on a repo that we control more directly, and we also discussed several of the reasons @vincerubinetti already mentioned. As the Manubot AI Editor code stabilizes, we can decide how to proceed, but for now I would move the documentation. The merging should happen when we have the documentation ready on the |
Now that manubot/manubot-ai-editor#42 is merged, I think this is ready to merge. |
Followup: manubot/manubot-ai-editor#44 |
No description provided.