Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pandoc-secnos to the build environment. #466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewturk
Copy link
Contributor

In conjunction with manubot/manubot#334 , this makes it possible to add section references to a manuscript. I have not updated the github hash for manubot referenced in the build environment, but will if/when that pull request is accepted.

A sample build of this is now in the yt paper build where you can see the number of sections referenced. I did note that all the sections are part of part 1, which I suspect might be an issue with the fact that I seem to be using ## as the base section number. That's probably fixable somehow on our end.

@AppVeyorBot
Copy link

AppVeyor build 1.0.281 for commit e923638 is now complete.

Found 51 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

Copy link
Member

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks reasonable to me. Thanks for updating the documentation.

It would make sense to merge manubot/manubot#334 first so we can update the manubot version in the environment here.

@dhimmel
Copy link
Member

dhimmel commented Apr 14, 2022

It would make sense to merge manubot/manubot#334 first so we can update the manubot version in the environment here

Yes, can upgrade manubot to manubot/manubot@fb39504

I'm in favor of adding pandoc-secnos if we think it's unlikely to break anything. For manuscripts without any @sec:... references, I'm hoping this filter will essentially do nothing.

Unfortunately, the pandoc-xnos suite hasn't been receiving frequent maintenance. So switching to pandoc-crossref is probably the right move for Manubot. However, the syntax is similar, so merging this should not interfere with switching.

@AppVeyorBot
Copy link

AppVeyor build 1.0.282 for commit 76924c1 is now complete.

Found 51 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants