useDebouncedCallback: add a flush method to returned callback #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scamden
force-pushed
the
patch-1
branch
2 times, most recently
from
22e1e48 to
2ca6650
Compare
|
Added tests, I think this is in a good state for review. Not sure who to at-ref here.. |
scamden
force-pushed
the
patch-1
branch
2 times, most recently
from
216589f to
eb7d587
Compare
scamden
commented
Dec 19, 2024
| }); | ||
|
|
||
|
|
||
| it('does not call after unmount if timer lapsed', () => { |
There was a problem hiding this comment.
this adds a test for the clearTimeout functionality in the useEffect, previously untested, not strictly related to this change :)
|
Please fix failing tests. |
Will do. I think it’s just formatting |
…d callback as well as give an option to simply flush on unmount
Fixed I believe, ran locally this time to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as give an option to simply flush on unmount, which is desirable when the callback does persisting of values (but not when it's just updating state obviously)