Fix TagsInput duplicate deletion behavior #6907
Conversation
|
Thanks! |
| @@ -336,7 +336,7 @@ export const TagsInput = factory<TagsInputFactory>((_props, ref) => { | |||
| key={`${item}-${index}`} | |||
| withRemoveButton={!readOnly} | |||
| onRemove={() => { | |||
| setValue(_value.filter((i) => item !== i)); | |||
| setValue(_value.splice(index, 1)); | |||
There was a problem hiding this comment.
Is this correct? I'm seeing that clicking X to remove a tag now removes all other tags except the target
There was a problem hiding this comment.
think I should've used .toSpliced here @adelamarAtGalileo can you let me know if this resolves it?
Seems alright to me, but clearly I missed it yesterday. Storybook must not have refreshed 🤷.
There was a problem hiding this comment.
splice modifies the array and returns the removed value
toSpliced doesn't modify the array and returns the remaining values
So yes, .toSpliced should work here
There was a problem hiding this comment.
skill issue (on my behalf). I've opened a PR. Thanks for catching :)
There was a problem hiding this comment.
nice, hopefully released soon, already got complaints from users :D
There was a problem hiding this comment.
@max-degterev You can downgrade to "@mantine/core": "^7.11.1" so you can avoid the newly introduced bug while waiting for a new release with the fix
There was a problem hiding this comment.
maybe @rtivital pushes this out soon, I keep my hopes up :)
fixes #6873