-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make analysis reduction a Mantid algorithm #128
Commits on Jul 29, 2024
-
Change unit test to avoid mocking
The unit test that existed before used a mock of mantid and of a table workspace to test. It is better practice to avoid mocking when possible, and this way the internal implementation of the unit test can change whilst maintaining the validity of the test.
Configuration menu - View commit details
-
Copy full SHA for 91c876e - Browse repository at this point
Copy the full SHA 91c876eView commit details
Commits on Jul 30, 2024
-
Create new folder for transitioning into oop
Started work to make analysis routine into an object. Created folder to keep my work organised.
Configuration menu - View commit details
-
Copy full SHA for 066767c - Browse repository at this point
Copy the full SHA 066767cView commit details -
Change most functions to be contained in object
Most of the work consisted in including 'self' in functions and replace the previous 'ic' methods with 'self' methods
Configuration menu - View commit details
-
Copy full SHA for a945aa8 - Browse repository at this point
Copy the full SHA a945aa8View commit details
Commits on Jul 31, 2024
-
The first part of the routine up until the MS and Gamma corrections is now working, have not tested it yet.
Configuration menu - View commit details
-
Copy full SHA for b6291d0 - Browse repository at this point
Copy the full SHA b6291d0View commit details -
Fixed second part of routine to use analysis object. Currently running in its entirety but have not checked tests
Configuration menu - View commit details
-
Copy full SHA for 3927498 - Browse repository at this point
Copy the full SHA 3927498View commit details
Commits on Aug 1, 2024
-
Fix system tests to run new analysis
Added a system test for the new AnalysisReduction object. All system tests are passing. The system tests have a coverage of 95% of analysis_reduction.py and are very stringent, so it is fairly safe to say that this transition to OOP has not introduced any new bugs.
Configuration menu - View commit details
-
Copy full SHA for 9ab2044 - Browse repository at this point
Copy the full SHA 9ab2044View commit details
Commits on Aug 2, 2024
-
Instead of fit the workspace in one go, and then create a table and the final workspaces, it makes more sense to populate the table and the final worksapaces row by row as the spectra are being fit row by row.
Configuration menu - View commit details
-
Copy full SHA for a4e2fa8 - Browse repository at this point
Copy the full SHA a4e2fa8View commit details
Commits on Aug 5, 2024
-
Cleaned fit of ncps to use object methods
- Renamed functions - Changed functions to use self._row_being_fit instead of using the row as a function argument - Deleted functions made redundant due to previous commit
Configuration menu - View commit details
-
Copy full SHA for d58bee7 - Browse repository at this point
Copy the full SHA d58bee7View commit details -
Clean masking of columns in input workspace
When the input workspace contains columns of zeros, these should be replaced by the fitted profile before doing the multiple scattering and gamma correction.
Configuration menu - View commit details
-
Copy full SHA for fa66910 - Browse repository at this point
Copy the full SHA fa66910View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0f79d7 - Browse repository at this point
Copy the full SHA e0f79d7View commit details
Commits on Aug 6, 2024
-
Clean calculation of means and corrections
Made it easier to read and understand what the routine is doing when calculating the mean widths and intensity ratios. Put the multiple scattering and gamma corrections into its own function.
Configuration menu - View commit details
-
Copy full SHA for f2b0f87 - Browse repository at this point
Copy the full SHA f2b0f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35bf3db - Browse repository at this point
Copy the full SHA 35bf3dbView commit details
Commits on Aug 7, 2024
-
Replace previous routine with new one
This work changes analysis_routines.py to be the "glue" between current interface and new oop interface. The idea is to keep the current interface for now and focus on turning the analysis rouinte into a Mantid algorithm. The analysis system tests were changed to account for this re-routing.
Configuration menu - View commit details
-
Copy full SHA for ba625de - Browse repository at this point
Copy the full SHA ba625deView commit details
Commits on Aug 8, 2024
-
Rewrite routine to link two analysis routines
Rewrote routine for chaining two analysis routines together, known as the 'JOINT' procedure. This means that the resulting means and intensities from one analysis routine, usually backscattering, are used as the starting guesses for forward routine, and all widths except the lightest element (usually Hydrogen) are fixed. New procedure using the AnalysisReduction object is easier to read and less prone to bugs. Also checked that figures and result files are saved at correct location.
Configuration menu - View commit details
-
Copy full SHA for aab0f15 - Browse repository at this point
Copy the full SHA aab0f15View commit details -
Removed system test that was testing old interface
The new AanalysisReduction class is already being tested by test_analysis.py so the removed test was redundant.
Configuration menu - View commit details
-
Copy full SHA for 7f9f2a1 - Browse repository at this point
Copy the full SHA 7f9f2a1View commit details
Commits on Aug 9, 2024
-
Clean procedure to estimate H ratio
Updated procedure to estimate H ratio to use new object of AnalysisReduction. The ratio is set to always be in relation to the lowest mass in the sample.
Configuration menu - View commit details
-
Copy full SHA for 6a66e5b - Browse repository at this point
Copy the full SHA 6a66e5bView commit details -
I added two functions to handle constraints with the new OOP interface, but promptly forgot that they are not necessary in the current interface as it is, so I commented them out for now, to be used in the future when the shift towards using the new interface happens
Configuration menu - View commit details
-
Copy full SHA for ea4498f - Browse repository at this point
Copy the full SHA ea4498fView commit details -
Tidy some small parts of the code
Made imports clearer, deleted useless comments and organized some sections into separate functions.
Configuration menu - View commit details
-
Copy full SHA for 1b9ba3a - Browse repository at this point
Copy the full SHA 1b9ba3aView commit details -
Delete old files and rename new ones
This commit finalizes the transition between the previous analysis routine using only functions and the new one using an object to run the routine. All of the intermediate files have been deleted and final routine was renamed to the existing analysis_reduction.py
Configuration menu - View commit details
-
Copy full SHA for d4614d0 - Browse repository at this point
Copy the full SHA d4614d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 959110a - Browse repository at this point
Copy the full SHA 959110aView commit details
Commits on Aug 12, 2024
-
Separated import statements by three groups of standard library, external imports and mvesuvio package imports
Configuration menu - View commit details
-
Copy full SHA for 457198e - Browse repository at this point
Copy the full SHA 457198eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0a2488 - Browse repository at this point
Copy the full SHA e0a2488View commit details -
Fix assertion and rename variables
Implemented review suggestions
Configuration menu - View commit details
-
Copy full SHA for 3caecae - Browse repository at this point
Copy the full SHA 3caecaeView commit details
Commits on Aug 22, 2024
-
Uncomment functions to use in the future
Configuration menu - View commit details
-
Copy full SHA for 68abc66 - Browse repository at this point
Copy the full SHA 68abc66View commit details -
Configuration menu - View commit details
-
Copy full SHA for f10fbf3 - Browse repository at this point
Copy the full SHA f10fbf3View commit details