Replace subtraction of profiles with Minus() #110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the subtraction of NCP profiles waas being done by extracting the data from a workspace into np arrays, doing the subtraction and the masking in the array and finally passing the arrays into a mantid workspace again. This can be simplified by using mantid Minus(). This has the advantage of preserving workspace metadata and handling masking automatically. - Changed analysis scripts so that ncp created have the same metadata as the original workspace, by using CloneWorkspace(). Otherwise Minus() will not work. - Added test data to fix missing workspace metadata and added workspace with the sum of ncp
- Updated the y space fit test for GC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the subtraction of NCP profiles was being done by extracting the data from a workspace into np arrays, doing the subtraction and the masking in the array and finally passing the arrays into a mantid workspace again.
This can be simplified by using mantid Minus().
This has the advantage of preserving workspace metadata and handling masking automatically.
Description of work:
To test:
Fixes #xxxx.