Skip to content

Fix ios run hook add shellscript #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidcyp
Copy link

@davidcyp davidcyp commented Oct 7, 2016

Hello,

We had trouble getting the shellScript running. After some investigation, we found out there was no 'Post-Compile' phase defined in our project.pbxproj. Because of that, the shellScript was not added to our project.pbxproj and the dSYM was not uploaded to the Fabric.io backend.

Therefore, we have rewritten the code which alters the project.pbxproj and now everything works fine. However, we guess the previous version of the script must have worked in the past, thus we are not sure we can simply override it by this version. Can you verify if our new version of the script doesn't break things.

For the sake of completeness, I have also added the steps we execute to register an app for the 1st time:

  • Download fabric mac app (https://fabric.io/downloads/apple)
  • Add new project
  • Build your app via CLI: appc run --platform ios -T device --fabric-enabled true --log-level debug
  • Select your Xcode Project (appear after building your appcelerator app for ios)
  • Select the organization
  • At Crashlytics, click "install"
  • Don't follow the instruction on that window, instead:
  • Build your app via CLI: appc run --platform ios -T device --fabric-enabled true --log-level debug
  • After a few seconds, the Fabric app will navigate to the next window
  • Don't follow the instructions on that window, instead:
  • Build your app via CLI: appc run --platform ios -T device --fabric-enabled true --log-level debug
  • After a few seconds, the Fabric app will show the "Done" button
  • Now click the "Done" button
  • Verify your OSX Console, check for the uploading dSYM eg. : 7/10/16 09:56:48,520 uploadDSYM[51191]: Uploading dSYM . If you don't find a similar message, please search the CLI console for TiFabric
  • Go to the Fabric.io website and verify if your app has been added

Kind regards,
David

David Cypers added 2 commits October 7, 2016 11:00
- add build phase
- adapt script

outcome: the script is executed and dsym is uploaded
@manojdcoder
Copy link
Owner

@davidcyp Thank you for all your efforts, please resolve the conflicts before I could merge this.

…ios_run_hook_add_shellscript

# Conflicts:
#	plugins/ti.fabric/cli/hooks/run.js
@davidcyp
Copy link
Author

davidcyp commented Oct 7, 2016

@manojdcoder done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants