Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for dongles #60

Merged

Conversation

RasmusKoit
Copy link
Contributor

Currently there is a code check for splitting firmware into left and right halves, this code change implements also splitting by _dongle or _central suffix

@RasmusKoit
Copy link
Contributor Author

Ran a test run with https://github.com/RasmusKoit/miryoku_zmk/actions/runs/10227455196/job/28298921969 for just _left and _right halves

Here is a test run with the same changes + outboard containing a dongle https://github.com/RasmusKoit/miryoku_zmk/actions/runs/10221908453

@RasmusKoit
Copy link
Contributor Author

i am also in the process of writing docs for dongles in the zmk repo here

@manna-harbour
Copy link
Owner

Thanks for the PR!

The suffix names aren't explicitly mentioned in your docs, but the examples use only dongle. Is central just an alternative to that? I guess for ZMK all of the suffix names are just convention, and they can actually be anything.

The workflow requires a list though. Perhaps just one name should be encouraged in the docs (as it is now) and supported in the workflow, for simplicity.

@RasmusKoit
Copy link
Contributor Author

will rework it to use central 👍

@manna-harbour
Copy link
Owner

Is central preferred over dongle? Is there a convention yet?

@RasmusKoit
Copy link
Contributor Author

Actually based on this zmkfirmware/zmk#2525 it seems that dongle will be used instead

@manna-harbour manna-harbour merged commit 87b05d6 into manna-harbour:master Dec 3, 2024
@manna-harbour
Copy link
Owner

Thanks!

@RasmusKoit RasmusKoit deleted the rasmuskoit/add_dongle_support branch December 3, 2024 10:16
alexportillo pushed a commit to alexportillo/miryoku_zmk that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants