Skip to content

Feat/issues#12 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Feat/issues#12 #19

wants to merge 6 commits into from

Conversation

Sadman95
Copy link

Pull Request Title

Description

Added command for creating controller, service and route and test added

Related Issue(s)

Changes Made

If yes, do [x].

  • Added a new feature
  • Fixed a bug
  • Refactored existing code
  • Updated documentation
  • Other (explain): added tests under tests dir for creating controller, service, route

List and describe the main changes here:

  1. create controller command
  2. create service command
  3. create route command

Checklist

Please ensure the following have been completed:
If yes, do [x].

  • Code compiles without errors
  • Tests are written and passing (if applicable)
  • Documentation is updated (in code or README as needed)
  • Code adheres to style guidelines (Prettier, ESLint)

Dependencies

  1. jest

Additional Notes

Kindly check my changes

Thank you

Copy link
Owner

@manishraj27 manishraj27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the code it does not pass es lint checl run npm run lint, npm run lint:fix

@Sadman95 Sadman95 requested a review from manishraj27 November 1, 2024 04:44
@Sadman95
Copy link
Author

Sadman95 commented Nov 1, 2024

Check the code it does not pass es lint checl run npm run lint, npm run lint:fix

yup
tests were out of eslint configuration. added that.

@manishraj27 manishraj27 marked this pull request as draft November 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants