Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash points associated with LFG. #199

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix crash points associated with LFG. #199

wants to merge 3 commits into from

Conversation

i-am-fyre
Copy link
Contributor

@i-am-fyre i-am-fyre commented Nov 3, 2024 •
edited by billy1arm
Loading

This fix will remove a few crash points associated with the Dungeon Finder feature.
It does NOT make everything else work - there are still some issues with fringe cases.

This change is Reviewable

@AppVeyorBot
Copy link

✅ Build Mangos TWO Server 22.02.103 completed (commit 804630063d by @i-am-fyre)

@AppVeyorBot
Copy link

✅ Build Mangos TWO Server 22.02.104 completed (commit b24470084a by @i-am-fyre)

Meltie2013
Meltie2013 suggested changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@Meltie2013 Meltie2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i-am-fyre Have a look what I suggested to you.

src/game/WorldHandlers/LFGMgr.cpp Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Build Mangos TWO Server 22.02.105 completed (commit fcf1c9caf1 by @i-am-fyre)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meltie2013 Meltie2013 Meltie2013 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-am-fyre @AppVeyorBot @Meltie2013