Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add connector mikoroku #7219

Merged
merged 4 commits into from
Jul 31, 2024
Merged

add connector mikoroku #7219

merged 4 commits into from
Jul 31, 2024

Conversation

akn19
Copy link
Contributor

@akn19 akn19 commented Jun 28, 2024

No description provided.

@MikeZeDev
Copy link
Contributor

This is totally copy pasted from a single connector where i had to use hacky stuff because the website was crappy.
Not sure it is anymore.

Was it tested?
In case it works try to remove the hacky stuff and see if it works again.

I ported it to Haruneko like this, maybe you can find some inspiration here : https://github.com/manga-download/haruneko/blob/master/web/src/engine/websites/NextScan.ts ?

@akn19
Copy link
Contributor Author

akn19 commented Jul 3, 2024

I've cleaned up the code. The code has been tested on several titles and there are no issues.

Copy link
Contributor

@MikeZeDev MikeZeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps _getChapters can be simplified?

src/web/mjs/connectors/Mikoroku.mjs Outdated Show resolved Hide resolved
@ronny1982
Copy link
Contributor

Suggestion to close PR after Friday, 20 September 2024 (12 weeks) if not approved by a reviewer.

@MikeZeDev MikeZeDev merged commit 850191f into manga-download:master Jul 31, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants