Update MangaPlus connector #7175
Conversation
|
There is another open PR #7112 for this website. |
|
please, update Mangaplus |
|
Use HaruNeko if it is that important to you |
|
I am tempted to close this in favor of my own PR but it could be badly interpreted :D |
|
Suggestion to close PR after Saturday, 31 August 2024 (12 weeks) if not approved by a reviewer. |
|
This lacks some langage supports i put in my own PR |
| @@ -2,7 +2,7 @@ | |||
| // Based on: https://mangaplus.shueisha.co.jp/js/app.a3091b24.js | |||
|
|
|||
| package MangaPlus; | |||
| syntax = "proto3"; | |||
| //syntax = "proto3"; | |||
There was a problem hiding this comment.
any reason why you removed this?
There was a problem hiding this comment.
for the record, i kept it uncommented, it still works without any error or warning in console...
There was a problem hiding this comment.
Sure. Just remove the comment then. Its like that in other proto files afaik, Better keep things similar.
| repeated Banner titleBanners = 20; | ||
| // optional UserTickets userTickets = 21; | ||
| repeated Chapter ticketChapterList = 22; | ||
| repeated Title ticketTitleList = 23; |
There was a problem hiding this comment.
I have the feeling than many of those are useless for our code. I think they can be omited, and protobuf will just skip them
| let data = await this.fetchPROTO(request, this.protoTypes, this.rootType); | ||
| return data.success.allTitlesView.titles.map(manga => { | ||
| return data.success.allTitlesViewV2.allTitlesGroup.flatMap(mangaGroup => mangaGroup.titles.map(manga => { | ||
| return { | ||
| id: manga.titleId, | ||
| title: `${manga.name} ${this._getLanguage(manga.language)}` |
There was a problem hiding this comment.
you should update language array
There was a problem hiding this comment.
i hate pictures of text (but i still love your PR), episode 65536:
0: '[en]', 1: '[es]', 2: '[fr]', 3: '[id]', 4: '[pt-br]', 5: '[ru]', 6: '[th]', 7: '[de]', 8: '[unk]', 9: '[vi]'
PS: what is this unk lang? i don't see it on shueisha manga list....
There was a problem hiding this comment.
I wasnt able to find the language for 8. But since we have a 9 we ought to have a 8 .
Feel free to do so. I just wanted to put this out into the world in case people didn't know how to implement the new API yet. Now that you've seen it you can close it and do it yourself if you prefer that way. |
|
We have more chances to get it done if i validate your PR than if we wait for mine to be reviewed by another dev. They are REALLY REALLY busy. |
No description provided.