Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create devcontainer config #7070

Closed

Conversation

TristanWasTaken
Copy link
Contributor

@TristanWasTaken TristanWasTaken commented May 7, 2024

Create devcontainer config.

It's used by gh's codespaces, VSCodes's devcontainer extensions and allows you to move your dev env to your local or an external docker host.

The config won't need any maintenance until Debian 12 (bookworm) or Node.js version 20 is deprecated, which would be in 2026. While the VSCode extensions might break or become incompatible, it will only affect the extension.

vscode:

I added a few VSCode extensions for convenience. Please tell me if I should remove any (or all) of them:

@ronny1982
Copy link
Contributor

ronny1982 commented May 7, 2024

I don't see much benefit for the following reasons:

  • codespaces/devcontainers are probably not commonly used by HakuNeko developers
  • codespaces cannot run electron or nw since an X server is not running
  • codespaces can be started via GitHub in browser without the need of a configuration file

@TristanWasTaken
Copy link
Contributor Author

fair. I wasn't really sure myself if it's worth it (which is why I asked on Discord beforehand)

* codespaces can be started via GitHub in browser without the need of a configuration file

I didn't know that it defaults to the node image and thought it's a barebone install. Kinda cursed, but you learn something new every day 😄

@TristanWasTaken TristanWasTaken deleted the devcontainer branch July 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants