Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ana06/[email protected] #607

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Jun 4, 2021

Use Ana06/[email protected] which removes the head commit is ahead of the base commit check. This made the action failed in not up-to-date branches (in which rebasing is needed).

I think we should update capa-rules and capa-testfiles as well.

It supersedes #599

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

Use Ana06/[email protected] which removes the _head commit is ahead
of the base commit_ check. This made the action failed in not up-to-date
branches (in which rebasing is needed).

It supersedes mandiant#599
@Ana06 Ana06 added the CI Continuous Integration configuration label Jun 4, 2021
@Ana06 Ana06 requested a review from mr-tz June 4, 2021 12:08
@mr-tz
Copy link
Collaborator

mr-tz commented Jun 4, 2021

cool, thanks, need to update this in capa-rules as well

@Ana06
Copy link
Member Author

Ana06 commented Jun 4, 2021

@mr-tz

cool, thanks, need to update this in capa-rules as well

and in capa-testfiles 😉

@mr-tz mr-tz merged commit 734b170 into mandiant:master Jun 7, 2021
@mr-tz mr-tz mentioned this pull request Jun 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants