change code in tag stats to match main stats page (publiclab#8679)

manchere · Feb 13, 2021 · 7984c83 · 7984c83
1 parent cb0fa52
commit 7984c83
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/app/controllers/tag_controller.rb b/app/controllers/tag_controller.rb
@@ -521,12 +521,11 @@ def stats
 
     @all_subscriptions = TagSelection.graph(@start, @end)
 
-    @answers = Node.published.questions
+    total_questions = Node.published.questions
       .where(created: @start.to_i..@end.to_i)
-      .where(nid: Node.find_by_tag(tagname)).joins(:comments).size
-    @questions = Node.published.questions
-      .where(created: @start.to_i..@end.to_i)
-      .where(nid: Node.find_by_tag(tagname)).size
+      .where(nid: Node.find_by_tag(tagname))
+    @answers = total_questions.joins(:comments).size.size
+    @questions = total_questions.size.size
   end
 
   private

diff --git a/app/views/tag/stats.html.erb b/app/views/tag/stats.html.erb
@@ -28,7 +28,7 @@
 </div>
 
 
-<% if @questions.count.nonzero? %>
+<% if @questions.nonzero? %>
     <br><br>
     <h4 align="center">Questions Answered vs. Unanswered</h4>
     <div align="right" id="questAns"> </div>