resolve race condition of get_buffer_content trying to read file content before handle_open_file finished #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing lsp-bridge in container gives me more edge case
This error happens constantly, get_buffer_content is trying to read file content before handle_open_file finished, when it happens, lsp stops working, that's why I'm having trouble using language server inside container.
We need to wrap the file access opeartion with lock to ensure the access is atomatic.
error log
With this change, the error no long happen, and language server works good, close #997