Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :type and add :safe function to defcustom variables #743

Merged

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Oct 19, 2023

Add :safe functions to defcustom to enable local variables.

This isn't important for all custom variables, but it's useful to be able to override them on a per-project basis in .dir-locals.el.

lsp-bridge.el Outdated
:group 'lsp-bridge)

(defcustom lsp-bridge-disable-backup t
"Default disable backup feature, include `make-backup-files' `auto-save-default' and `create-lockfiles'."
:type 'boolean
:safe #'stringp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥是stringp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I fixed it.

@manateelazycat manateelazycat merged commit 9bb84af into manateelazycat:master Oct 19, 2023
1 check passed
@manateelazycat
Copy link
Owner

感谢补丁, 我还不知道 :safe 关键字。 ;)

@zonuexe zonuexe deleted the feature/add-custom-safe branch October 19, 2023 16:39
@zonuexe zonuexe restored the feature/add-custom-safe branch October 19, 2023 16:39
@zonuexe zonuexe deleted the feature/add-custom-safe branch October 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants