Add search word candidates fuzzy match support #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/search_file_words.py
Outdated
| @@ -35,6 +36,8 @@ def __init__(self): | |||
| self.search_words_thread = None | |||
|
|
|||
| (self.max_number, ) = get_emacs_vars(["acm-backend-search-file-words-max-number"]) | |||
There was a problem hiding this comment.
这几个 get emacs vars应该合并程一个，这样性能会好一点。
core/search_file_words.py
Outdated
| @@ -26,6 +26,7 @@ | |||
| import re | |||
|
|
|||
| from core.utils import * | |||
| from rapidfuzz import fuzz | |||
There was a problem hiding this comment.
这个import要移动到代码中，避免用户一更新就挂了
|
好的，改好了
---- Replied Message ----
| From | Andy ***@***.***> |
| Date | 08/30/2023 21:12 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [manateelazycat/lsp-bridge] Add search word candidates fuzzy match support (PR #705) |
@manateelazycat commented on this pull request.
In core/search_file_words.py:
@@ -26,6 +26,7 @@
import re
from core.utils import *
+from rapidfuzz import fuzz
这个import要移动到代码中，避免用户一更新就挂了
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement fuzzy matching for the search word using rapidfuzz