Highlight the Symbol you want to see while peeking to find it. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
能先把那些缩进的行去掉吗？要不是没办法看这个补丁 |
|
抱歉大佬，我开了自动格式化 现在把缩进去掉了，麻烦再看看 🙏 |
|
@kongds 能帮忙看一下这个补丁吗？谢谢 |
好的 |
kongds
reviewed
Aug 1, 2023
lsp-bridge-peek.el
Outdated
| :extend t)) | ||
| (put-text-property highlight-begin highlight-end 'face '(:background "#623d73" :foreground "white")) | ||
| (setq file-content (concat (buffer-substring beg end) "\n")) | ||
| (put-text-property highlight-begin highlight-end 'face '(:background (background-color-at-point)))) |
There was a problem hiding this comment.
这块用remove-text-properties会不会更好一点
lsp-bridge-peek.el
Outdated
| (lsp-bridge--add-face file-content | ||
| (list :background lsp-bridge-peek--bg | ||
| :extend t)) | ||
| (put-text-property highlight-begin highlight-end 'face '(:background "#623d73" :foreground "white")) |
There was a problem hiding this comment.
这个highlight的face 定义一个单独face 可能会方便用户设置
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.