Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set-visited-file-name for remote docker file #1004

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

nohzafk
Copy link
Contributor

@nohzafk nohzafk commented Jul 30, 2024

Remove it will make things just work, keeping buffer as a non-file buffer

  • aphelia formatter will work with remote file
  • use set-visited-file-name will result in saving the file twice, and we have to deal with buffer modtime, and unsaved change.
  • keep the same logic as remote SSH file

Update README about how to use formatter with remote file.

@manateelazycat manateelazycat merged commit d54ffdf into manateelazycat:master Jul 30, 2024
1 check passed
@manateelazycat
Copy link
Owner

Thanks for patch

@manateelazycat
Copy link
Owner

@nohzafk Looks strange, d54ffdf will make github action failed.

@nohzafk
Copy link
Contributor Author

nohzafk commented Jul 31, 2024

is it Ok right now? the code has nothing special in it

@manateelazycat
Copy link
Owner

It's not bug of lsp-birdge, it's issue purcell/setup-emacs#49 (comment)

@nohzafk
Copy link
Contributor Author

nohzafk commented Jul 31, 2024

thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants