Fixup getting project path on Windows

[md11235]

Sometimes ‘git rev-parse —show-toplevel’ is used in core/utils.py to get project path for an existing source file. That git subcommand would convert a Windows style path like “f:/foo/bar.py” to “/f/foo” and cause unexpected behavior on Windows OS’s.

I’ve made a possible fix to that git behavior. Thank you for reviewing this patch.

[manateelazycat]

@md11235
Thanks for patch, can you tell me what's value of path_from_git in your system? And what's your target string for windows_path?

I think it's dangerous if we direct access 1 or 2 index in path_parts, will maybe crash lsp-bridge.

[md11235]

Thank you for you reply. You're correct about this.

Previously I only tested the git command provided MSYS2 (https://www.msys2.org/). And I've instead tested the git command provided by "Git for Windows" (https://gitforwindows.org/) just now and it behaved differently.

Suppose f:/foo is a local git repository. In MSYS2, git rev-parse --show-toplevel f:/foo/bar.py produces:

/f/foo

Yet in "Git For Windows", git rev-parse --show-toplevel f:/foo/bar.py produces:

F:/foo

So it's just the git command from MSYS2 when using the subcommand rev-parse has the problem of converting Windows-style path to a Unix-style one.

[md11235]

Thank you for you reply. You're correct about this.

Previously I only tested the git command provided MSYS2 (https://www.msys2.org/). And I've instead tested the git command provided by "Git for Windows" (https://gitforwindows.org/) just now and it behaved differently.

Suppose f:/foo is a local git repository. In MSYS2, git rev-parse --show-toplevel f:/foo/bar.py produces:

/f/foo

Yet in "Git For Windows", git rev-parse --show-toplevel f:/foo/bar.py produces:

F:/foo

So it's just the git command from MSYS2 when using the subcommand rev-parse has the problem of converting Windows-style path to a Unix-style one.

Both these git commands were executed on Windows 10(Version 10.0.19045.4651).

[manateelazycat]

This line should change to:

if get_os_name() == "windows" and path_from_git.startswith("/"):

[manateelazycat]

Or only run convert code when env is MSYS2

[manateelazycat]

thanks for patch