Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elao - App -Docker] Allow directory slash in app name #405

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[Elao - App -Docker] Allow directory slash in app name #405

merged 1 commit into from
Dec 6, 2023

Conversation

ogizanagi
Copy link
Member

@ogizanagi ogizanagi commented Dec 6, 2023 •
edited
Loading

So we can use release & deploy with Manala when the apps from a monorepo are placed in a subdir, like apps/xxx

Done

  • Fixed release on GitHub actions

LATER

  • fixup deploy on GitHub actions (deployment_url)

@ogizanagi ogizanagi requested a review from nervo December 6, 2023 12:50
@ogizanagi
[Elao - App -Docker] Allow directory slash in app name
12b58b0 
So we can use release & deploy with Manala when the apps from a monorepo are placed in a subdir, like `apps/xxx`
@ogizanagi ogizanagi merged commit 5d0cb19 into master Dec 6, 2023
1 of 2 checks passed
@ogizanagi ogizanagi deleted the elao.app.docker-dir-app branch December 6, 2023 16:06
@ogizanagi ogizanagi mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nervo nervo nervo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogizanagi @nervo