-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading JSON files #155
Open
SaarthShah
wants to merge
8
commits into
mammothb:master
Choose a base branch
from
SaarthShah:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Loading JSON files #155
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aadb8e9
added support for load json
SaarthShah 359e380
adding _words
SaarthShah 4cb585c
removed Count key
SaarthShah 6cdacdc
json update
SaarthShah 12033d6
faster loading
SaarthShah 4670b5e
async loading
SaarthShah 05bcb24
load_json back to async
SaarthShah 413820a
faster loading
SaarthShah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bypasses
create_dictionary_entry
which contains logic to handle only adding to_words
if it reaches above thecount_threshold
.create_dictionary_entry
should be used so that the behavior of loading a dictionary from.txt
or.json
file is consistent